Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

Nik john/add material ui ssr#158

Merged
nik-john merged 8 commits into
freeCodeCamp:masterfrom
nik-john:nik-john/add-material-ui-SSR
Nov 1, 2019
Merged

Nik john/add material ui ssr#158
nik-john merged 8 commits into
freeCodeCamp:masterfrom
nik-john:nik-john/add-material-ui-SSR

Conversation

@nik-john

@nik-john nik-john commented Oct 31, 2019

Copy link
Copy Markdown
Contributor
  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the master branch of Chapter.

Material UI stylesheet also need to be rendered on the server side. This PR adds this change and adds a sample component as per Official Material UI Docs

timmyichen
timmyichen approved these changes Oct 31, 2019
View reviewed changes

@timmyichen timmyichen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread pages/index.tsx
font-size: 50px;
color: ${({ theme }) => theme.colors.primary};
`;

@timmyichen timmyichen Oct 31, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add back in some example of using styled components for future contributors?

@nik-john nik-john Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmyichen Yup, done.

@ThomasRoest

ThomasRoest commented Oct 31, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

thoughts about folder structure? My preference would be

MyComponent
      -- index.tsx
      -- styles.ts

@nik-john

nik-john commented Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

@ThomasRoest Agreed. Not sure why we didn't do that already, but I've made the change

@nik-john nik-john merged commit c1cf448 into freeCodeCamp:master Nov 1, 2019
@vaibhavsingh97 vaibhavsingh97 deleted the nik-john/add-material-ui-SSR branch November 1, 2019 05:07
@Zeko369 Zeko369 mentioned this pull request Nov 6, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@timmyichen timmyichen timmyichen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nik-john @ThomasRoest @timmyichen